Re: [PATCH v2 1/2] Teach reset the same short-hand as checkout

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 10, 2015, 02:34 UTC
Message-ID: <xmqq385d60o3.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1425888936-23370-1-git-send-email-sudshekhar02@gmail.com>

Sudhanshu Shekhar <sudshekhar02@gmail.com> writes:

Show 5 quoted lines

> "-" now means the previous branch.
>
> Signed-off-by: Sudhanshu Shekhar <sudshekhar02@gmail.com>
> Thanks-to: Eric Sunshine, Junio C Hamano, Matthieu Moy
> ---

These look unusual for a few reasons: your S-o-b should be at the end, we usually say Helped-by: instead, and we do not use these with multiple names on a single line.

Please do not try to be original without a good reason. We may start counting the number of times people appear on these footers to see how much contribution those who do not directly author commits (read: those who mentor others) are making.

>  builtin/reset.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)

The comment I gave in the thread that ends at $gmane/265112 would apply equally to this patch, I think.

cf. http://thread.gmane.org/gmane.comp.version-control.git/264986/focus=265112