Re: [PATCH v2 1/2] Teach reset the same short-hand as checkout

From: Sudhanshu Shekhar <sudshekhar02@gmail.com>
Date: Mar 10, 2015, 07:37 UTC
Message-ID: <CAODo60pDGeX+VtuhvByduBzvmFabH4GVH-xe-dcMou_Zz=C7vg@mail.gmail.com>
In-Reply-To: <xmqq385d60o3.fsf@gitster.dls.corp.google.com>

Hi,

On Tue, Mar 10, 2015 at 8:04 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 17 quoted lines

> Sudhanshu Shekhar <sudshekhar02@gmail.com> writes:
>
>> "-" now means the previous branch.
>>
>> Signed-off-by: Sudhanshu Shekhar <sudshekhar02@gmail.com>
>> Thanks-to: Eric Sunshine, Junio C Hamano, Matthieu Moy
>> ---
>
>
> These look unusual for a few reasons: your S-o-b should be at the
> end, we usually say Helped-by: instead, and we do not use these with
> multiple names on a single line.
>
> Please do not try to be original without a good reason.  We may
> start counting the number of times people appear on these footers to
> see how much contribution those who do not directly author commits
> (read: those who mentor others) are making.

Thank you for telling me this. I will it keep it in mind from next time onwards.

Show 8 quoted lines

>
>>  builtin/reset.c | 9 ++++++++-
>>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> The comment I gave in the thread that ends at $gmane/265112 would
> apply equally to this patch, I think.
>
> cf. http://thread.gmane.org/gmane.comp.version-control.git/264986/focus=265112

I have rectified this in my new patch and will send it soon. Kindly do let me know if there are any other changes required.

Thank you. Regards, Sudhanshu