git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] builtin/apply: free patch when parse_chunk() fails

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 31, 2016, 22:56 UTC
Message-ID
<xmqq37r6l0il.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<CAP8UFD2uT8dF+LMEGVdM6QZztqr_FbX=UQ01U0ttODFUk4AxbA@mail.gmail.com>
Christian Couder <christian.couder@gmail.com> writes:
Show 10 quoted lines
> On Wed, Mar 16, 2016 at 3:35 PM, Christian Couder
> <christian.couder@gmail.com> wrote:
>> When parse_chunk() fails it can return -1, for example
>> when find_header() doesn't find a patch header.
>>
>> In this case it's better in apply_patch() to free the
>> "struct patch" that we just allocated instead of
>> leaking it.
>
> Maybe this patch has fallen through the cracks too.

Anything worthy of discussion that you sent during the feature freeze, please resend them to the list for discussion.

Previous: Christian CouderNext: Christian Couder
Message 3 of 5 in “builtin/apply: free patch when parse_chunk() fails”
  1. builtin/apply: free patch when parse_chunk() failsChristian Couder, Mar 16, 2016
  2. Christian CouderMar 31, 2016
  3. Junio C HamanoMar 31, 2016
  4. Christian CouderMar 31, 2016
  5. Junio C HamanoApr 1, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.