From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 31 Mar 2016 22:56:34 GMT
Subject: Re: [PATCH] builtin/apply: free patch when parse_chunk() fails
Message-ID: <xmqq37r6l0il.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAP8UFD2uT8dF+LMEGVdM6QZztqr_FbX=UQ01U0ttODFUk4AxbA@mail.gmail.com>

Christian Couder <christian.couder@gmail.com> writes:

> On Wed, Mar 16, 2016 at 3:35 PM, Christian Couder
> <christian.couder@gmail.com> wrote:
>> When parse_chunk() fails it can return -1, for example
>> when find_header() doesn't find a patch header.
>>
>> In this case it's better in apply_patch() to free the
>> "struct patch" that we just allocated instead of
>> leaking it.
>
> Maybe this patch has fallen through the cracks too.

Anything worthy of discussion that you sent during the feature
freeze, please resend them to the list for discussion.