git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] replace --edit: respect core.editor

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 20, 2016, 15:29 UTC
Message-ID
<xmqq37qgxprl.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20160420065349.GA14490@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 9 quoted lines
> On Wed, Apr 20, 2016 at 08:38:03AM +0200, Johannes Schindelin wrote:
>
>> We simply need to read the config, is all.
>> 
>> This fixes https://github.com/git-for-windows/git/issues/733
>> 
>> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> Looks good to me. Thanks.

Yup, I think the new placement is at the most logical place, just before parse options. I looked at other codepaths and I do not see a reason why they shouldn't read the configuration variables.

Thanks, both.
Previous: Jeff King
Message 10 of 10 in “replace --edit: respect core.editor”
  1. replace --edit: respect core.editorJohannes Schindelin, Apr 19, 2016
  2. Junio C HamanoApr 19, 2016
  3. Jeff KingApr 20, 2016
  4. Christian CouderApr 20, 2016
  5. Johannes SchindelinApr 20, 2016
  6. Johannes SchindelinApr 20, 2016
  7. Junio C HamanoApr 20, 2016
  8. replace --edit: respect core.editorJohannes Schindelin, Apr 20, 2016
  9. Jeff KingApr 20, 2016
  10. Junio C HamanoApr 20, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.