From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 20 Apr 2016 15:29:18 GMT
Subject: Re: [PATCH v2] replace --edit: respect core.editor
Message-ID: <xmqq37qgxprl.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160420065349.GA14490@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Wed, Apr 20, 2016 at 08:38:03AM +0200, Johannes Schindelin wrote:
>
>> We simply need to read the config, is all.
>> 
>> This fixes https://github.com/git-for-windows/git/issues/733
>> 
>> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> Looks good to me. Thanks.

Yup, I think the new placement is at the most logical place, just
before parse options.  I looked at other codepaths and I do not see
a reason why they shouldn't read the configuration variables.

Thanks, both.