Re: [PATCH] t0008: 4 tests fail with ksh88

From: Junio C Hamano <gitster@pobox.com>
Date: May 20, 2016, 15:16 UTC
Message-ID: <xmqq37pchi90.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CALR6jEhviK9KZxR6R6xzkZ5EAO-RjWj3xYah_DOSDXhEjYsT-A@mail.gmail.com>

Armin Kunaschik <megabreit@googlemail.com> writes:

> From: Armin Kunaschik <megabreit@googlemail.com>
>
> \" in the test t0008 is not treated the same way in bash and in ksh.

Could you refrain from singling out "bash"? We don't write for "bash" specifically (and the test I ran are with "dash" before I push things out).

Ideally, if you can try ksh93 and if you find out that ksh93 works, then the above can be made in line with your "Subject" to mark ksh88 as broken (as opposed to other POSIX shells)? That would help us by reminding that running test fine with ksh93 is not a sufficient check to make sure we didn't break ksh88 users.

> In ksh the \ disappears and generates false expect data to
> compare with.
> Using \\" works portable, the same way in bash and in ksh and
> is less ambigous.

All of the above would need s/ksh/&88/g; I'd think.  I just tried

	make SHELL_PATH=/bin/ksh93
        cd t && /bin/ksh93 t0008-*.sh

and this patch is not necessary for ksh93.

> Acked-by: Jeff King <peff@peff.net>

I didn't see him acking this exact version, so if you didn't include this line here, I would have missed it. Thanks.

Show 24 quoted lines

> Signed-off-by: Armin Kunaschik <megabreit@googlemail.com>
> ---
> diff --git a/t/t0008-ignores.sh b/t/t0008-ignores.sh
> index 89544dd..b425f3a 100755
> --- a/t/t0008-ignores.sh
> +++ b/t/t0008-ignores.sh
> @@ -605,7 +605,7 @@ cat <<-EOF >expected-verbose
>         a/b/.gitignore:8:!on*   a/b/one
>         a/b/.gitignore:8:!on*   a/b/one one
>         a/b/.gitignore:8:!on*   a/b/one two
> -       a/b/.gitignore:8:!on*   "a/b/one\"three"
> +       a/b/.gitignore:8:!on*   "a/b/one\\"three"
>         a/b/.gitignore:9:!two   a/b/two
>         a/.gitignore:1:two*     a/b/twooo
>         $global_excludes:2:!globaltwo   globaltwo
> @@ -686,7 +686,7 @@ cat <<-EOF >expected-all
>         a/b/.gitignore:8:!on*   b/one
>         a/b/.gitignore:8:!on*   b/one one
>         a/b/.gitignore:8:!on*   b/one two
> -       a/b/.gitignore:8:!on*   "b/one\"three"
> +       a/b/.gitignore:8:!on*   "b/one\\"three"
>         a/b/.gitignore:9:!two   b/two
>         ::      b/not-ignored
>         a/.gitignore:1:two*     b/twooo