git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t0008: 4 tests fail with ksh88

From
Jeff King <peff@peff.net>
Date
May 22, 2016, 00:07 UTC
Message-ID
<20160522000756.GA9591@sigill.intra.peff.net>
In-Reply-To
<xmqq37pchi90.fsf@gitster.mtv.corp.google.com>
On Fri, May 20, 2016 at 08:16:43AM -0700, Junio C Hamano wrote:
> > Acked-by: Jeff King <peff@peff.net>
> 
> I didn't see him acking this exact version, so if you didn't include
> this line here, I would have missed it.  Thanks.

I don't think I ever saw an actual patch to ack until now; I just said the idea seemed good.

That being said, the patch _does_ look good, and I am fine to have my ack/reviewed-by on it (though I agree with your points regarding the commit message).

-Peff
Previous: Armin Kunaschik
Message 7 of 7 in “t0008: 4 tests fail with ksh88”
  1. t0008: 4 tests fail with ksh88Armin Kunaschik, May 20, 2016
  2. Junio C HamanoMay 20, 2016
  3. Junio C HamanoMay 20, 2016
  4. Armin KunaschikMay 20, 2016
  5. Christian CouderMay 20, 2016
  6. Armin KunaschikMay 20, 2016
  7. Jeff KingMay 22, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.