Re: Bad refspec messes up bundle.

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 30, 2018, 17:18 UTC
Message-ID: <xmqq370h4h4b.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <nycvar.QRO.7.76.6.1803301102430.5026@qfpub.tvgsbejvaqbjf.bet>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 13 quoted lines

> Hi Luciano,
>
>> > Is this a bug? Should bundle allow providing multiple refspecs when
> ...
> I agree that it is a bug if a bundle file records a ref multiple times.
> Luciano, here are some pointers so you can fix it:
>
> - probably the best way to start would be to add a new test case to
>   t/t5607-clone-bundle.sh. The script *should* be relatively easy to
>   understand and imitate. The new test case would probably look somewhat
>   like this:
>
> 	test_expect_failure 'bundles must not contain multiple refs' '

s/multiple/duplicate/. It is not unusual for a bundle to record more than one ref; it is (1) useless and harmful to unsuspecting clients to record the same ref twice with the same value and (2) nonesnse to record the same ref twice with different value.

Other than that, the outline seems to go in the right general direction.