Re: Bad refspec messes up bundle.

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 30, 2018, 18:58 UTC
Message-ID: <nycvar.QRO.7.76.6.1803302056570.5026@qfpub.tvgsbejvaqbjf.bet>
In-Reply-To: <xmqq370h4h4b.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Fri, 30 Mar 2018, Junio C Hamano wrote:

Show 18 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> >> > Is this a bug? Should bundle allow providing multiple refspecs when
> > ...
> > I agree that it is a bug if a bundle file records a ref multiple
> > times.  Luciano, here are some pointers so you can fix it:
> >
> > - probably the best way to start would be to add a new test case to
> >   t/t5607-clone-bundle.sh. The script *should* be relatively easy to
> >   understand and imitate. The new test case would probably look somewhat
> >   like this:
> >
> > 	test_expect_failure 'bundles must not contain multiple refs' '
> 
> s/multiple/duplicate/.  It is not unusual for a bundle to record
> more than one ref; it is (1) useless and harmful to unsuspecting
> clients to record the same ref twice with the same value and (2)
> nonesnse to record the same ref twice with different value.

Of course! Thanks for pointing this out.

> Other than that, the outline seems to go in the right general
> direction.

Excellent.

Luciano, the ball is in your court now. If you get stuck with anything (such as getting started with building Git), please let us know. We can help.

Ciao, Johannes