Re: [PATCH v2 3/3] http: automatically retry some requests

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 13, 2020, 21:14 UTC
Message-ID: <xmqq362hkew3.fsf@gitster.c.googlers.com>
In-Reply-To: <20201013191729.2524700-3-smcallis@google.com>

Sean McAllister <smcallis@google.com> writes:

Show 7 quoted lines

>  test_expect_success 'partial clone using HTTP with redirect' '
> -	_NONCE=`gen_nonce` && export _NONCE &&
> +	_NONCE=$(gen_nonce) &&
>  	curl "$HTTPD_URL/error_ntime/${_NONCE}/3/502/10/smart/server" &&
>  	curl "$HTTPD_URL/error_ntime/${_NONCE}/3/502/10/smart/server" &&
>  	curl "$HTTPD_URL/error_ntime/${_NONCE}/3/502/10/smart/server" &&
>  	partial_clone "$HTTPD_DOCUMENT_ROOT_PATH/server" "$HTTPD_URL/error_ntime/${_NONCE}/3/502/10/smart/server"

It also bothers me somewhat that we waste 40 seconds waiting to complete this test, most of the time just sleeping.

Now, do we still need gen_nonce in the test library, now there is only one or two tests, both in a single test script?

Thanks.