Re: [PATCH v2 2/3] replace CURLOPT_FILE With CURLOPT_WRITEDATA

From: Jeff King <peff@peff.net>
Date: Oct 13, 2020, 20:58 UTC
Message-ID: <20201013205841.GA3678071@coredump.intra.peff.net>
In-Reply-To: <xmqq7drtkg6o.fsf@gitster.c.googlers.com>

On Tue, Oct 13, 2020 at 01:46:07PM -0700, Junio C Hamano wrote:

Show 8 quoted lines

> Sean McAllister <smcallis@google.com> writes:
> 
> > CURLOPT_FILE has been deprecated since 2003.
> 
> I thought that Dscho already mention this, but updating the above
> description to mention that _WRITEDATA was introduce to overtake
> _FILE as an equivalent in the same timeframe would be more helpful
> to readers.

Yes. But more important:

  - when is _FILE going away (or has it already in some versions)?

  - when did _WRITEDATA appear?

IOW, as a reviewer I would want to make sure that we are not losing support for any reasonable version of libcurl, or that we are at least getting something in return (fixing an incompatibility with newer versions).

From the link Dscho dug up it looks like the answer to the second one is "long enough not to care", but the commit message should make that plain.

-Peff