Re: [PATCH] svn: use correct variable name for short OID

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 22, 2020, 19:29 UTC
Message-ID: <xmqq3626m53d.fsf@gitster.c.googlers.com>
In-Reply-To: <20201022032400.GC1480820@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> The fact that we have to touch every perl file is a bit ugly. So I
> dunno. Maybe worth it, or maybe too nasty.

Just a single pragma per file? That does not sound too bad at least to me.

Thanks, queued.

Show 6 quoted lines

> Note that the mapping from the GIT_TEST_* form to the GIT_* form in
> test-lib.sh is necessary even if they had the same name: the perl
> scripts need it to be normalized to a perl truth value, and we also have
> to make sure it's exported (we might have gotten it from the
> environment, but we might also have gotten it from GIT-BUILD-OPTIONS
> directly).

And GIT_PERL_FATAL_WARNINGS is cleared together with the other GIT_* options upfront, so here we only need to worry about setting and exporting it. Makes sense.

Show 17 quoted lines

> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index ef31f40037..dfad820dd4 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -499,6 +499,12 @@ then
>  	export GIT_INDEX_VERSION
>  fi
>  
> +if test -n "$GIT_TEST_PERL_FATAL_WARNINGS"
> +then
> +	GIT_PERL_FATAL_WARNINGS=1
> +	export GIT_PERL_FATAL_WARNINGS
> +fi
> +
>  # Add libc MALLOC and MALLOC_PERTURB test
>  # only if we are not executing the test with valgrind
>  if test -n "$valgrind" ||