Re: git svn log: Use of uninitialized value $sha1_short

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Oct 21, 2020, 22:21 UTC
Message-ID: <20201021222158.GJ490427@camp.crustytoothpaste.net>
In-Reply-To: <xmqqwnzj5mq5.fsf@gitster.c.googlers.com>

On 2020-10-21 at 20:48:50, Junio C Hamano wrote:

Show 19 quoted lines

> Looks that way.  '$::' as opposed to plain '$' threw the replacement
> off the track?
> 
>  perl/Git/SVN/Log.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git i/perl/Git/SVN/Log.pm w/perl/Git/SVN/Log.pm
> index 3858fcf27d..9c819188ea 100644
> --- i/perl/Git/SVN/Log.pm
> +++ w/perl/Git/SVN/Log.pm
> @@ -298,7 +298,7 @@ sub cmd_show_log {
>  			get_author_info($c, $1, $2, $3);
>  		} elsif (/^${esc_color}(?:tree|parent|committer) /o) {
>  			# ignore
> -		} elsif (/^${esc_color}:\d{6} \d{6} $::sha1_short/o) {
> +		} elsif (/^${esc_color}:\d{6} \d{6} $::oid_short/o) {
>  			push @{$c->{raw}}, $_;
>  		} elsif (/^${esc_color}[ACRMDT]\t/) {
>  			# we could add $SVN->{svn_path} here, but that requires

Yeah, this is correct. I'll try to get a format patch written up tonight with this if nobody gets to it before me.

-- 
brian m. carlson (he/him or they/them)
Houston, Texas, US