Re: [PATCH v6 0/2] t7501: add tests for --include, --only, --signoff
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 17, 2024, 21:33 UTC
- Message-ID
- <xmqq34uvwspa.fsf@gitster.g>
- In-Reply-To
- <20240117161421.17333-1-shyamthakkar001@gmail.com>
Ghanshyam Thakkar <shyamthakkar001@gmail.com> writes:
Show 13 quoted lines
> The v6 addresses the comments from Junio, which suggested to improve the > TODO comment describing the potential bug for --include. Also, replace > here-doc with expected output file for better debugging, as suggested by > Junio. > > --signoff tests remain unchanged. > > Ghanshyam Thakkar (2): > t7501: add tests for --include and --only > t7501: add tests for --amend --signoff > > t/t7501-commit-basic-functionality.sh | 98 ++++++++++++++++++++++++++- > 1 file changed, 96 insertions(+), 2 deletions(-)
Looks quite good. Let's declare victory and merge it down to 'next' soonish.
Thanks.