Re: [PATCH 0/2][GSOC] t7501: Add tests for various index usages, -i and -o, of commit command and amending commit to add signoff.

From: Christian Couder <christian.couder@gmail.com>
Date: Jan 9, 2024, 09:32 UTC
Message-ID: <CAP8UFD2W3JCXQCRV9ekzMbcPHW+LmWBxm_WOKkEZDD=Tnjj_mg@mail.gmail.com>
In-Reply-To: <20240109060417.1144647-2-shyamthakkar001@gmail.com>

On Tue, Jan 9, 2024 at 7:10 AM Ghanshyam Thakkar <shyamthakkar001@gmail.com> wrote:

Show 7 quoted lines

>
> This patch series adds tests for various index usages, -i and -o, of commit
> command and amending commit to add Signed-of-by trailer. This is in
> reference to the comment added in commit 12ace0b2 which reads:
>
>   # FIXME: Test the various index usages, -i and -o, test reflog,
>   # signoff, hooks

It seems to me that the patch series should remove or change that FIXME if it resolves it, or some parts of it.

For example I would expect the patch that adds -i and -o related tests to remove at least "-i and -o, " from that FIXME comment.

> Ghanshyam Thakkar (2):
>   t7501: Add tests for various index usages, -i and -o, of commit
>     command.
>   t7501: Add test for amending commit to add signoff.

I commented on the first patch, and I took a look at the second one. It seems to me that a number of comments I made on the first one are valid for the second one as well. For a micro-project I would suggest focussing on only one patch though. As we say in https://git.github.io/General-Microproject-Information/, we want quality, not quantity! You can always work on other possible bigger things after your micro-project is merged.

Thanks!