git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fetch-pack: Remove unused struct 'loose_object_iter'

From
Junio C Hamano <gitster@pobox.com>
Date
May 13, 2024, 23:56 UTC
Message-ID
<xmqq34qlcllg.fsf@gitster.g>
In-Reply-To
<ZkHlUkKtqbXSvVNS@tanuki>
Patrick Steinhardt <ps@pks.im> writes:
Show 11 quoted lines
> On Sun, May 12, 2024 at 01:59:13AM +0100, Dr. David Alan Gilbert wrote:
>
> Tiny nit: we don't capitalize the first letter after the colon in the
> subject. I don't think this warrants a reroll of this patch though.
>
>> 'loose_object_iter' in fetch-pack.c is unused since
>> commit 97b2fa08b6b9ee3e ("fetch-pack: drop custom loose object cache")
>> Remove it.
>
> Good catch, and thanks for providing historical context. The patch looks
> obviously good to me.

Thanks, both. Will queue with a slight copy-editing of the proposed log message.

Previous: Patrick SteinhardtNext: Jeff King
Message 3 of 5 in “fetch-pack: Remove unused struct 'loose_object_iter'”
  1. fetch-pack: Remove unused struct 'loose_object_iter'Dr. David Alan Gilbert, May 12, 2024
  2. Patrick SteinhardtMay 13, 2024
  3. Junio C HamanoMay 13, 2024
  4. Jeff KingMay 15, 2024
  5. Dr. David Alan GilbertMay 15, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.