Re: [PATCH] fetch-pack: Remove unused struct 'loose_object_iter'

From: Jeff King <peff@peff.net>
Date: May 15, 2024, 06:46 UTC
Message-ID: <20240515064658.GE110841@coredump.intra.peff.net>
In-Reply-To: <20240512005913.342287-1-dave@treblig.org>

On Sun, May 12, 2024 at 01:59:13AM +0100, Dr. David Alan Gilbert wrote:

> 'loose_object_iter' in fetch-pack.c is unused since
> commit 97b2fa08b6b9ee3e ("fetch-pack: drop custom loose object cache")
> Remove it.

Thanks, this was my fault for leaving it in. The patch looks obviously good.

I wish there was a good way to get the compiler to report on unused types, but I don't think there is (it's a complicated problem in general, but file-local ones like this feel like they should be easy to spot).

Here's a really hacky (and quadratic) attempt to find defined structs that aren't mentioned elsewhere:

  for i in $(git grep -ho '^struct [a-z_]* {' | cut -d' ' -f2)
  do
	used=$(git grep -Phc "\b$i\b" |
	       perl -ne '$x += $_; END { print $x }')
	echo "$used $i"
  done |
  sort -n

which finds exactly one unused struct, the one in this patch.

-Peff