git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] reftable: mark unused parameters in empty iterator functions

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 28, 2024, 17:12 UTC
Message-ID
<xmqq34mo1si1.fsf@gitster.g>
In-Reply-To
<20240828040944.GA4005021@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
> This should go on top of ps/reftable-drop-generic. Arguably this could
> have been done as part of the conflict resolution when merging into next
> alongside jk/mark-unused-parameters, but at this point I think a
> separate patch is the best way forward.

As marking with UNUSED used to be optional before -Wno-unused-param got removed, I agree that it is better to apply this on top to be explicit, rather than burying it in an evil merge with a topic that marked other unrelated parameters as UNUSED.

Previous: Patrick SteinhardtNext: Jeff King
Message 3 of 4 in “reftable: mark unused parameters in empty iterator functions”
  1. reftable: mark unused parameters in empty iterator functionsJeff King, Aug 28, 2024
  2. Patrick SteinhardtAug 28, 2024
  3. Junio C HamanoAug 28, 2024
  4. Jeff KingAug 28, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.