From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 28 Aug 2024 17:12:22 GMT
Subject: Re: [PATCH] reftable: mark unused parameters in empty iterator functions
Message-ID: <xmqq34mo1si1.fsf@gitster.g>
In-Reply-To: <20240828040944.GA4005021@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> This should go on top of ps/reftable-drop-generic. Arguably this could
> have been done as part of the conflict resolution when merging into next
> alongside jk/mark-unused-parameters, but at this point I think a
> separate patch is the best way forward.

As marking with UNUSED used to be optional before -Wno-unused-param
got removed, I agree that it is better to apply this on top to be
explicit, rather than burying it in an evil merge with a topic that
marked other unrelated parameters as UNUSED.