Re: [PATCH] Makefile: fix dependency for $(UNIT_TEST_DIR)/clar/clar.o

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 10, 2024, 18:50 UTC
Message-ID: <xmqq34l3lrlx.fsf@gitster.g>
In-Reply-To: <C05B01E0-5007-4FB9-94CD-CBE74E79F9B7@gmail.com>

Philippe Blain <levraiphilippeblain@gmail.com> writes:

> I had a closer look at how the header dependencies are handled in
> the Makefile and I think a cleaner and more idiomatic way to fix
> the problem would be to add clar.suite to GENERATED_H.

If it is a header file (e.g. we could run "make hdr-check" on it to make sure it is self-contained, if we wanted to check it), that sounds like a very appropriate thing to do.

> I’ll try to send a v2 tomorrow so maybe hold on to merging it to
> next for the moment, Junio.

Thanks.