Re: [PATCH v2] Makefile: fix dependency for $(UNIT_TEST_DIR)/clar/clar.o

From: Taylor Blau <me@ttaylorr.com>
Date: Oct 15, 2024, 00:34 UTC
Message-ID: <Zw24fMNMTK14EqfL@nand.local>
In-Reply-To: <Zw0HmISykehEiC-p@pks.im>

On Mon, Oct 14, 2024 at 01:59:25PM +0200, Patrick Steinhardt wrote:

Show 13 quoted lines

> On Fri, Oct 11, 2024 at 05:29:47PM +0000, Philippe Blain via GitGitGadget wrote:
> > From: Philippe Blain <levraiphilippeblain@gmail.com>
> >
> > The clar source file '$(UNIT_TEST_DIR)/clar/clar.c' includes the
> > generated 'clar.suite', but this dependency is not taken into account by
> > our Makefile, so that it is possible for a parallel build to fail if
> > Make tries to build 'clar.o' before 'clar.suite' is generated.
> >
> > Correctly specify the dependency.
> >
> > Signed-off-by: Philippe Blain <levraiphilippeblain@gmail.com>
>
> Thanks, this version looks good to me.

Thanks, both. Junio had already marked this one to merge to 'next', so I will go ahead and merge it down in the next integration cycle (which should be tomorrow, assuming I remember how to do it correctly).

Thanks, Taylor