Re: [PATCH v2 0/4] When fetching from a promisor remote, repack local objects referenced

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 4, 2024, 02:05 UTC
Message-ID: <xmqq34k7ycry.fsf@gitster.g>
In-Reply-To: <xmqq7c9jyhjb.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 6 quoted lines

> You may already have noticed this, but with this topic merged,
> 'seen' seems to start failing leak checker jobs e.g.
>
> https://github.com/git/git/actions/runs/11642458705
>   https://github.com/git/git/actions/runs/11642458705/job/32422074222#step:4:1964
>   https://github.com/git/git/actions/runs/11642458705/job/32422074132#step:4:1963

With this patch, t5300 no longer seems to leak (when the topic is tested alone, at least).

 builtin/index-pack.c | 1 +
 1 file changed, 1 insertion(+)

diff --git c/builtin/index-pack.c w/builtin/index-pack.c
index e4afd6725f..08b340552f 100644
--- c/builtin/index-pack.c
+++ w/builtin/index-pack.c
@@ -1821,6 +1821,7 @@ static void repack_local_links(void)
 	if (finish_command(&cmd))
 		die(_("could not finish pack-objects to repack local links"));
 	strbuf_release(&line);
+	free(base_name);
 }
 
 int cmd_index_pack(int argc,