Re: [PATCH v2] index-pack: teach --promisor to forbid pack name

From: Jeff King <peff@peff.net>
Date: Nov 20, 2024, 06:29 UTC
Message-ID: <20241120062919.GA4564@coredump.intra.peff.net>
In-Reply-To: <20241119201016.22713-1-jonathantanmy@google.com>

On Tue, Nov 19, 2024 at 12:10:15PM -0800, Jonathan Tan wrote:

> Thanks, Peff, for the catch. Here's an updated patch, with an updated
> commit message.

This looks good to me, thanks.

Show 21 quoted lines

> Range-diff against v1:
> [...]
>     @@ Commit message
>          test here any more.)
>      
>          [1] https://lore.kernel.org/git/20241114005652.GC1140565@coredump.intra.peff.net/
>     +    [2] https://lore.kernel.org/git/20241119185345.GB15723@coredump.intra.peff.net/
>      
>          Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
>          ---
>          This is on jt/repack-local-promisor.
>      
>     -    Looking into it further, I think that we also need to require no
>     -    packfile name to be given (so that we are writing the file to the
>     -    repository). Therefore, I've added that requirement both in the code and
>     -    in the documentation.
>     -
>     -    I've tried to summarize our conversation in the commit message - if you
>     -    notice anything missing or incorrect, feel free to let me know.
>     +    Thanks, Peff, for the catch. Here's an updated patch, with an updated
>     +    commit message.

Heh, I guess you stick your notes directly into the commit message. ;) I do that sometimes, too. A long time ago I had a patch that would let you write "---" in the commit message editor and then auto-convert that into actual notes. Probably not that big a deal, though.

-Peff