Re: What's cooking in git.git (Dec 2024, #01; Tue, 3)

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 3, 2024, 23:09 UTC
Message-ID: <xmqq34j4bbz5.fsf@gitster.g>
In-Reply-To: <Z07auxNCcysPovdo@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 18 quoted lines

>> * ps/send-pack-unhide-error-in-atomic-push (2024-11-15) 6 commits
>>  - push: not send push-options to server with --dry-run
>>  - push: only ignore finish_connect() for dry-run mode
>>  - t5543: atomic push reports exit code failure
>>  - t5504: modernize test by moving heredocs into test bodies
>>  - push: fix the behavior of the Done message for porcelain
>>  - t5548: new test cases for push --porcelain and --dry-run
>> 
>>  "git push --atomic --porcelain" used to ignore failures from the
>>  other side, losing the error status from the child process, which
>>  has been corrected.
>> 
>>  Probably needs a redesign.
>>  cf. <Z0Q0wfSTk_cUXH0F@pks.im>
>>  source: <cover.1731603991.git.zhiyou.jx@alibaba-inc.com>
>
> I wonder whether we want to roll with the first version that I have sent
> instead of using v2 from Jiang.

That's a thought.  Let's go back to the series and take a look.

Thanks.