git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (Dec 2024, #01; Tue, 3)

From
karthik nayak <karthik.188@gmail.com>
Date
Dec 3, 2024, 14:46 UTC
Message-ID
<CAOLa=ZT1queYRwTK2a-yB+XXiY0kdBnuuuo5ptbWhfsY69tmcA@mail.gmail.com>
In-Reply-To
<Z07auxNCcysPovdo@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 21 quoted lines
> On Tue, Dec 03, 2024 at 03:48:10PM +0900, Junio C Hamano wrote:
>> * kn/midx-wo-the-repository (2024-11-28) 10 commits
>>  - midx: inline the `MIDX_MIN_SIZE` definition
>>  - midx: pass down `hash_algo` to functions using global variables
>>  - midx: pass `repository` to `load_multi_pack_index`
>>  - midx: cleanup internal usage of `the_repository` and `the_hash_algo`
>>  - midx-write: pass down repository to `write_midx_file[_only]`
>>  - write-midx: add repository field to `write_midx_context`
>>  - midx-write: use `revs->repo` inside `read_refs_snapshot`
>>  - midx-write: pass down repository to static functions
>>  - Merge branch 'kn/pass-repo-to-builtin-sub-sub-commands' into kn/midx-wo-the-repository
>>  - Merge branch 'kn/the-repository' into kn/midx-wo-the-repository
>>  (this branch uses kn/pass-repo-to-builtin-sub-sub-commands and kn/the-repository.)
>>
>>  Yet another "pass the repository through the callchain" topic.
>>
>>  Will merge to 'next'?
>>  source: <20241127-374-refactor-midx-c-and-midx-write-c-to-not-depend-on-global-state-v3-0-c5a99f85009b@gmail.com>
>
> This series looks good to me.
>
Thanks Patrick.
[snip]
Show 23 quoted lines
>> * kn/the-repository (2024-11-27) 10 commits
>>  - packfile.c: remove unnecessary prepare_packed_git() call
>>  - midx: add repository to `multi_pack_index` struct
>>  - config: make `packed_git_(limit|window_size)` non-global variables
>>  - config: make `delta_base_cache_limit` a non-global variable
>>  - packfile: pass down repository to `for_each_packed_object`
>>  - packfile: pass down repository to `has_object[_kept]_pack`
>>  - packfile: pass down repository to `odb_pack_name`
>>  - packfile: pass `repository` to static function in the file
>>  - packfile: use `repository` from `packed_git` directly
>>  - packfile: add repository to struct `packed_git`
>>  (this branch is used by kn/midx-wo-the-repository.)
>>
>>  Various implicit uses of 'the_repoository' in the packfile code
>>  have been eliminated.
>>
>>  Will merge to 'next'?
>>  source: <cover.1732618495.git.karthik.188@gmail.com>
>
> I think there were two nits that Karthik has addressed but not yet sent
> out. May make sense to wait for that final reroll before merging it
> down.
>

I was holding out on re-rolling since they were minor, but I think it is best addressed, I've pushed a new version with the fixes now, we should be good to merge it to 'next'. Thanks both.

Previous: Patrick SteinhardtNext: Junio C Hamano
Message 3 of 5 in “What's cooking in git.git (Dec 2024, #01; Tue, 3)”
  1. Junio C HamanoDec 3, 2024
  2. Patrick SteinhardtDec 3, 2024
  3. karthik nayakDec 3, 2024
  4. Junio C HamanoDec 3, 2024
  5. Toon ClaesDec 3, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.