git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] repo: show subcommand-specific help text

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 25, 2026, 16:55 UTC
Message-ID
<xmqq341nx30z.fsf@gitster.g>
In-Reply-To
<acOye5MbsFVOa1vJ@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 13 quoted lines
>> v3:
>> - include the requested code changes that were missing from v2
>> - factor shared usage strings into macros to avoid duplication
>> - restore blank lines between tests and before test_done
>
> By the way, it is highly recommended to respond to some of the review
> mails directly, as it helps to create a dialog between submitter and
> reviewer. Otherwise reviewers may feel as if they are talking to a code
> emitting entity :)
>
> It's not necessary to reply to every single mail, but going like "Oops,
> yes, I indeed forgot to add the request code changes. Will fix in the
> next version" can go a long way to make the interaction more social.

Hear! hear! A new iteration without any introduction is harder to accept without such a pre-warning to suggest what the author thought after getting suggestions in earlier reviews. Did they agree and took the suggestion? Did they disagree but took the suggestion anyway, and if so why did they think the suggestion was not such a good change? Did they disagree and did not take the suggestion and if so why? They changed the code but not in the way suggested in the review, but why the new way was thought to be better than both the original and the reviewer input is unknown?

Previous: Patrick Steinhardt
Message 10 of 10 in “repo: show subcommand-specific help text”
  1. repo: show subcommand-specific help textMahi Kassa, Mar 23, 2026
  2. Derrick StoleeMar 23, 2026
  3. Patrick SteinhardtMar 24, 2026
  4. repo: show subcommand-specific help textMahi Kassa, Mar 24, 2026
  5. Patrick SteinhardtMar 24, 2026
  6. Derrick StoleeMar 24, 2026
  7. repo: show subcommand-specific help textMahi Kassa, Mar 24, 2026
  8. Derrick StoleeMar 24, 2026
  9. Patrick SteinhardtMar 25, 2026
  10. Junio C HamanoMar 25, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.