Re: [PATCH v3] repo: show subcommand-specific help text
- From
Derrick Stolee <stolee@gmail.com>
- Date
- Mar 24, 2026, 19:15 UTC
- Message-ID
- <017a4371-3b63-456a-9ca8-e36d6e9dc7d3@gmail.com>
- In-Reply-To
- <20260324184843.299223-1-mahlet.takassa@gmail.com>
On 3/24/2026 2:48 PM, Mahi Kassa wrote:
Show 8 quoted lines
> Use subcommand-specific usage arrays for "git repo info" and > "git repo structure" so that each command shows only its own > synopsis in help output. > > Factor the shared usage strings into macros to avoid > duplicating the same synopsis text in multiple arrays. > > Add tests to cover the subcommand help behavior.
You need a sign-off in your commit message.
> The previous reroll mistakenly omitted the requested code > changes; this version includes them.
This kind of information needs to be below the --- along with your "V3" changes:
Show 5 quoted lines
> --- > v3: > - include the requested code changes that were missing from v2 > - factor shared usage strings into macros to avoid duplication > - restore blank lines between tests and before test_done
(here)
Outside of these issues with the message, the diff itself looks good.
Thanks, -Stolee