git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 0/2] repository: move fetch_if_missing into struct repository

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 14, 2026, 14:44 UTC
Message-ID
<xmqq33wgrcco.fsf@gitster.g>
In-Reply-To
<20260814072419.1666358-1-cat@malon.dev>
Tian Yuchen <cat@malon.dev> writes:
Show 16 quoted lines
>  Documentation/technical/partial-clone.adoc |  2 +-
>  builtin/fetch-pack.c                       |  6 +++---
>  builtin/fsck.c                             |  6 +++---
>  builtin/index-pack.c                       |  8 +++----
>  builtin/pack-objects.c                     | 25 ++++++++++++----------
>  builtin/prune.c                            |  2 +-
>  builtin/rev-list.c                         | 17 ++++++++-------
>  common-init.c                              |  2 +-
>  git.c                                      |  2 +-
>  midx-write.c                               |  2 +-
>  odb.c                                      |  4 +---
>  odb.h                                      |  8 -------
>  repository.c                               |  1 +
>  repository.h                               |  6 ++++++
>  revision.c                                 |  2 +-
>  15 files changed, 47 insertions(+), 46 deletions(-)
$ git grep -e 'the_repository->fetch_if_missing' \
    builtin/{fetch-pack,fsck,index-pack,pack-objects,prune,rev-list}.c \
    common-init.c midx-write.c odb.c repository.c revision.c
common-init.c:          the_repository->fetch_if_missing = 0;

Compared to the previous round, there is no remaining reference to the_repository's '.fetch_if_missing' member. There is a reference in common-init.c:setup_environment() that reacts to the GIT_NO_LAZY_FETCH environment variable, but that does not count.

Much better.
Thanks.
Previous: Tian YuchenNext: Tian Yuchen
Message 23 of 26 in “repository: move fetch_if_missing into struct repository”
  1. repository: move fetch_if_missing into struct repositoryTian Yuchen, Jul 15, 2026
  2. Junio C HamanoJul 15, 2026
  3. Tian YuchenJul 15, 2026
  4. Patrick SteinhardtJul 15, 2026
  5. Tian YuchenJul 16, 2026
  6. Junio C HamanoJul 16, 2026
  7. repository: move fetch_if_missing into struct repositoryTian Yuchen, Jul 16, 2026
  8. Tian YuchenAug 1, 2026
  9. Patrick SteinhardtAug 4, 2026
  10. Junio C HamanoAug 4, 2026
  11. Tian YuchenAug 5, 2026
  12. Tian YuchenAug 5, 2026
  13. repository: move fetch_if_missing into struct repositoryTian Yuchen, Aug 7, 2026
  14. Junio C HamanoAug 7, 2026
  15. Tian YuchenAug 9, 2026
  16. repository: move fetch_if_missing into struct repositoryTian Yuchen, Aug 13, 2026
  17. Junio C HamanoAug 13, 2026
  18. 0/2 repository: move fetch_if_missing into struct repositoryTian Yuchen, Aug 14, 2026
  19. 1/2 pack-objects: give fetch_if_missing call sites access to 'repo'Tian Yuchen, Aug 14, 2026
  20. Junio C HamanoAug 14, 2026
  21. Tian YuchenAug 15, 2026
  22. 2/2 repository: move fetch_if_missing into struct repositoryTian Yuchen, Aug 14, 2026
  23. Junio C HamanoAug 14, 2026
  24. repository: move fetch_if_missing into struct repositoryTian Yuchen, Aug 15, 2026
  25. Junio C HamanoAug 15, 2026
  26. Tian YuchenAug 16, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.