From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 14 Aug 2026 14:44:07 GMT
Subject: Re: [PATCH v5 0/2] repository: move fetch_if_missing into struct repository
Message-ID: <xmqq33wgrcco.fsf@gitster.g>
In-Reply-To: <20260814072419.1666358-1-cat@malon.dev>

Tian Yuchen <cat@malon.dev> writes:

>  Documentation/technical/partial-clone.adoc |  2 +-
>  builtin/fetch-pack.c                       |  6 +++---
>  builtin/fsck.c                             |  6 +++---
>  builtin/index-pack.c                       |  8 +++----
>  builtin/pack-objects.c                     | 25 ++++++++++++----------
>  builtin/prune.c                            |  2 +-
>  builtin/rev-list.c                         | 17 ++++++++-------
>  common-init.c                              |  2 +-
>  git.c                                      |  2 +-
>  midx-write.c                               |  2 +-
>  odb.c                                      |  4 +---
>  odb.h                                      |  8 -------
>  repository.c                               |  1 +
>  repository.h                               |  6 ++++++
>  revision.c                                 |  2 +-
>  15 files changed, 47 insertions(+), 46 deletions(-)

$ git grep -e 'the_repository->fetch_if_missing' \
    builtin/{fetch-pack,fsck,index-pack,pack-objects,prune,rev-list}.c \
    common-init.c midx-write.c odb.c repository.c revision.c
common-init.c:          the_repository->fetch_if_missing = 0;

Compared to the previous round, there is no remaining reference to
the_repository's '.fetch_if_missing' member.  There is a reference
in common-init.c:setup_environment() that reacts to the
GIT_NO_LAZY_FETCH environment variable, but that does not count.

Much better.

Thanks.