Re: [PATCH v2] repack: do not rebuild packs on --dry-run

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 11, 2026, 05:57 UTC
Message-ID: <xmqq33ucg4oo.fsf@gitster.g>
In-Reply-To: <BBCEC2F7-CA8A-4460-8A4F-D8305D3E9134@gmail.com>

Ben Knoble <ben.knoble@gmail.com> writes:

Show 16 quoted lines

>>  ...
>> Fix it by returning right after the candidates are listed, and add a
>> test that checks the pack directory is unchanged with and without -d.
>> 
>> Reported-by: Coy Geek <coygeek@gmail.com>
>> Helped-by: D. Ben Knoble <ben.knoble@gmail.com>
>> Signed-off-by: Siddharth Shrimali <r.siddharth.shrimali@gmail.com>
>> ---
>> Bug report:
>> https://lore.kernel.org/git/CACgTecOm+=vbf50tZNXhcYvRi1ZTsQwbjVoJAbQqs2CmXdJCxg@mail.gmail.com/
>> 
>> Changes since v1:
>> - reworded the comment
>> - documented the bug in the log message
>
> Thanks, I’m happy with this version. You may add my Reviewed-by, if you like

Thanks for writing and reviewing.  Let me mark the topic for 'next'.