Re: [PATCH] repack: do not rebuild packs on --dry-run

From: Siddharth Shrimali <r.siddharth.shrimali@gmail.com>
Date: Oct 10, 2026, 20:05 UTC
Message-ID: <CAGWgyh-rwcHaZ4ymn1n1_RC+eCEomfAeJOT0GSUtU6oBmRbhcA@mail.gmail.com>
In-Reply-To: <xmqqwlrs2rvc.fsf@gitster.g>

Hi Junio,

On Thu, 8 Oct 2026 at 19:53, Junio C Hamano <gitster@pobox.com> wrote:

> Very interesting finding.  I am curious if this was the case from
> the beginning, or we broke --dry-run unknowingly as a side effect of
> some unrelated changes.  If it is not too much, can you bisect and
> document where we broke it in the log message?

unfortunately, this was a mistake on my end and it has been broken since --dry-run was introduced in 1e746b00aa. the --dry-run block never returned early, so it always went on to do a regular repack, including the deletion when -d is given explicitly.

I will document this in the log message in v2

Thanks, Siddharth