git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] t5300: modernize test path checks in t5300

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 29, 2026, 18:36 UTC
Message-ID
<xmqq33to2w1p.fsf@gitster.g>
In-Reply-To
<20261029120210.3722-1-ogundipesolataiwo12@gmail.com>
Ogundipe Sola Taiwo <ogundipesolataiwo12@gmail.com> writes:
Show 12 quoted lines
> Replace `test -f` commands with `test_path_is_file`, because
> it makes debugging a failing test easier by reporting what
> expectation was not met.
>
> Signed-off-by: Ogundipe Sola Taiwo <ogundipesolataiwo12@gmail.com>
> ---
> Changes in v3:
> - Rephrase patch summary to state how the use of `test_path_is_file`
> 	improves the debugging of failing tests.
>
>  t/t5300-pack-object.sh | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
Will queue.  Thanks.
Previous: Ogundipe Sola Taiwo
Message 11 of 11 in “[Outreachy] Microproject: Modernize file check in t5300-pack-object.sh”
  1. Ogundipe Sola TaiwoOct 23, 2026
  2. t5300: modernize test path checks in t5300Ogundipe Sola Taiwo, Oct 26, 2026
  3. Usman AkinyemiOct 27, 2026
  4. Usman AkinyemiOct 26, 2026
  5. t5300: modernize test path checks in t5300Ogundipe Sola Taiwo, Oct 27, 2026
  6. Usman AkinyemiOct 28, 2026
  7. Junio C HamanoOct 28, 2026
  8. Ogundipe Sola TaiwoOct 27, 2026
  9. Ogundipe Sola TaiwoOct 29, 2026
  10. t5300: modernize test path checks in t5300Ogundipe Sola Taiwo, Oct 29, 2026
  11. Junio C HamanoOct 29, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.