git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t5300: modernize test path checks in t5300

From
Usman Akinyemi <usmanakinyemi202@gmail.com>
Date
Oct 27, 2026, 16:56 UTC
Message-ID
<CAPSxiM85tDse=qD8cEP42uyGFV9JTJYV8_98SWTm1wTmWj7kPw@mail.gmail.com>
In-Reply-To
<20261026102017.2689-1-ogundipesolataiwo12@gmail.com>

On Mon, Oct 26, 2026 at 11:20 AM Ogundipe Sola Taiwo <ogundipesolataiwo12@gmail.com> wrote:

>
> This commit improves test t5300-pack-object by converting old-style

Could you rephrase this to avoid “This commit”? It's redundant in a commit message." Please describe the change directly instead. Also, I believe, the term patch is more appropriate and not "commit".

> path checks to use the `test_path_is_file` helper function.
>
> Signed-off-by: Ogundipe Sola Taiwo <ogundipesolataiwo12@gmail.com>
> ---
Apart from that, the changes looks good to me.
> --
> 2.56.0.116.g6de20f6092.dirty
>
Previous: Ogundipe Sola TaiwoNext: Usman Akinyemi
Message 3 of 11 in “[Outreachy] Microproject: Modernize file check in t5300-pack-object.sh”
  1. Ogundipe Sola TaiwoOct 23, 2026
  2. t5300: modernize test path checks in t5300Ogundipe Sola Taiwo, Oct 26, 2026
  3. Usman AkinyemiOct 27, 2026
  4. Usman AkinyemiOct 26, 2026
  5. t5300: modernize test path checks in t5300Ogundipe Sola Taiwo, Oct 27, 2026
  6. Usman AkinyemiOct 28, 2026
  7. Junio C HamanoOct 28, 2026
  8. Ogundipe Sola TaiwoOct 27, 2026
  9. Ogundipe Sola TaiwoOct 29, 2026
  10. t5300: modernize test path checks in t5300Ogundipe Sola Taiwo, Oct 29, 2026
  11. Junio C HamanoOct 29, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.