Re: [PATCH] t5300: modernize test path checks in t5300
- From
Usman Akinyemi <usmanakinyemi202@gmail.com>
- Date
- Oct 27, 2026, 16:56 UTC
- Message-ID
- <CAPSxiM85tDse=qD8cEP42uyGFV9JTJYV8_98SWTm1wTmWj7kPw@mail.gmail.com>
- In-Reply-To
- <20261026102017.2689-1-ogundipesolataiwo12@gmail.com>
On Mon, Oct 26, 2026 at 11:20 AM Ogundipe Sola Taiwo <ogundipesolataiwo12@gmail.com> wrote:
> > This commit improves test t5300-pack-object by converting old-style
Could you rephrase this to avoid “This commit”? It's redundant in a commit message." Please describe the change directly instead. Also, I believe, the term patch is more appropriate and not "commit".
> path checks to use the `test_path_is_file` helper function. > > Signed-off-by: Ogundipe Sola Taiwo <ogundipesolataiwo12@gmail.com> > ---
Apart from that, the changes looks good to me.
> -- > 2.56.0.116.g6de20f6092.dirty >