git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] repack: add `repack.honorpackkeep` config var

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 24, 2014, 19:10 UTC
Message-ID
<xmqq1tys9vie.fsf@gitster.dls.corp.google.com>
In-Reply-To
<20140224082459.GA32594@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 24 quoted lines
> Sorry, this one slipped through the cracks. Here's a re-roll addressing
> your comments.
> ...
>>  - In the context of "pack-objects", the name "--honor-pack-keep"
>>    makes sense; it is understood that pack-objects will _not_ remove
>>    kept packfile, so "honoring" can only mean "do not attempt to
>>    pick objects out of kept packs to add to the pack being
>>    generated." and there is no room for --no-honor-pack-keep to be
>>    mistaken as "you canremove the ones marked to be kept after
>>    saving the still-used objects in it away."
>> 
>>    But does the same name make sense in the context of "repack"?
>
> I think the distinction you are making is to capture the second second
> from the docs:
>
>   If set to false, include objects in `.keep` files when repacking via
>   `git repack`. Note that we still do not delete `.keep` packs after
>   `pack-objects` finishes.
>
> The best name I could come up with is "--pack-keep-objects", since that
> is literally what it is doing. I'm not wild about the name because it is
> easy to read "keep" as a verb (and "pack" as a noun). I think it's OK,
> but suggestions are welcome.
pack-kept-objects then?
Previous: Jeff KingNext: Jeff King
Message 11 of 27 in “WIth git-next, writing bitmaps fails when keep files are present”
  1. Siddharth AgarwalJan 23, 2014
  2. Siddharth AgarwalJan 23, 2014
  3. pack-objects: turn off bitmaps when skipping objectsJeff King, Jan 23, 2014
  4. Siddharth AgarwalJan 23, 2014
  5. Siddharth AgarwalJan 23, 2014
  6. Jeff KingJan 24, 2014
  7. Siddharth AgarwalJan 24, 2014
  8. repack: add `repack.honorpackkeep` config varJeff King, Jan 28, 2014
  9. Junio C HamanoJan 28, 2014
  10. Jeff KingFeb 24, 2014
  11. Junio C HamanoFeb 24, 2014
  12. Jeff KingFeb 26, 2014
  13. Junio C HamanoFeb 26, 2014
  14. Jeff KingFeb 27, 2014
  15. Junio C HamanoFeb 27, 2014
  16. Jeff KingFeb 28, 2014
  17. Nasser GrainawiFeb 28, 2014
  18. Jeff KingMar 1, 2014
  19. Shawn PearceMar 3, 2014
  20. Junio C HamanoFeb 28, 2014
  21. Jeff KingMar 1, 2014
  22. Junio C HamanoMar 3, 2014
  23. Jeff KingMar 3, 2014
  24. Junio C HamanoMar 3, 2014
  25. Jeff KingMar 3, 2014
  26. Vicent MartíJan 23, 2014
  27. Jeff KingJan 24, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.