Re: [PATCH] repack: add `repack.honorpackkeep` config var

From: Jeff King <peff@peff.net>
Date: Feb 27, 2014, 11:27 UTC
Message-ID: <20140227112734.GC29668@sigill.intra.peff.net>
In-Reply-To: <xmqqr46p39cj.fsf@gitster.dls.corp.google.com>

On Wed, Feb 26, 2014 at 12:30:36PM -0800, Junio C Hamano wrote:

Show 13 quoted lines

> >> pack-kept-objects then?
> >
> > Hmm. That does address my point above, but somehow the word "kept" feels
> > awkward to me. I'm ambivalent between the two.
> 
> That word does make my backside somewhat itchy ;-)
> 
> Would it help to take a step back and think what the option really
> does?  Perhaps we should call it --pack-all-objects, which is short
> for --pack-all-objectsregardless-of-where-they-currently-are-stored,
> or something?  The word "all" gives a wrong connotation in a
> different way (e.g. "regardless of reachability" is a possible wrong
> interpretation), so that does not sound too good, either.

I do not think "all" is what we want to say. It only affects "kept" objects, not any of the other exclusions (e.g., "-l").

> "--repack-kept-objects"?  "--include-kept-objects"?

Of all of them, I think --pack-kept-objects is probably the best. And I think we are hitting diminishing returns in thinking too much more on the name. :)

-Peff