git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v9 4/4] tag: support configuring --sort via .gitconfig

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 16, 2014, 21:40 UTC
Message-ID
<xmqq1ttlrnh5.fsf@gitster.dls.corp.google.com>
In-Reply-To
<1405545219.15392.17.camel@jekeller-desk1.amr.corp.intel.com>
"Keller, Jacob E" <jacob.e.keller@intel.com> writes:
Show 11 quoted lines
>> After all, it seems to me that the one in
>> 
>>     http://thread.gmane.org/gmane.comp.version-control.git/253346
>> 
>> struck the right balance among various abuses; let's use the error
>> reporter from that version, instead of going down this rabbit hole.
>> 
>> Thanks.
>
> So is that patch series version acceptable then? Or should I spin one
> again that is in that vein?

I do not offhand know what other changes you had in v9 since $gmane/253346, so I'll leave it up to you. If the only difference is the error reporting codepath, and you are happy with what I have in my tree

    $ git log -p --reverse -3 a93d886b9

then we can proceed with that version. Have there been any issues raised on that older version other than error reporting?

Previous: Keller, Jacob ENext: Keller, Jacob E
Message 10 of 11 in “usage: make error functions a stack”
  1. 1/4 usage: make error functions a stackJacob Keller, Jul 15, 2014
  2. 2/4 tag: fix --sort tests to use cat<<-\EOF formatJacob Keller, Jul 15, 2014
  3. 3/4 tag: update parsing to be more precise regarding errorsJacob Keller, Jul 15, 2014
  4. 4/4 tag: support configuring --sort via .gitconfigJacob Keller, Jul 15, 2014
  5. Jeff KingJul 15, 2014
  6. Keller, Jacob EJul 15, 2014
  7. Junio C HamanoJul 16, 2014
  8. Keller, Jacob EJul 16, 2014
  9. Keller, Jacob EJul 16, 2014
  10. Junio C HamanoJul 16, 2014
  11. Keller, Jacob EJul 16, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.