git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v9 4/4] tag: support configuring --sort via .gitconfig

From
Jeff King <peff@peff.net>
Date
Jul 15, 2014, 23:42 UTC
Message-ID
<20140715234240.GB5572@peff.net>
In-Reply-To
<1405467179-16064-4-git-send-email-jacob.e.keller@intel.com>
On Tue, Jul 15, 2014 at 04:32:59PM -0700, Jacob Keller wrote:
> +static void error_bad_sort_config(const char *err, va_list params)
> +{
> +	vreportf("warning: tag.sort has ", err, params);
> +}

This feels a little like an abuse of the "prefix" field of vreportf, but as you probably saw in my "for fun" patch, doing it right means formatting into a buffer and then reformatting that (which we're already doing again in vreportf, but less flexibly). I dunno.

At any rate, this should be marked for translation, no?
-Peff
Previous: Jacob KellerNext: Keller, Jacob E
Message 5 of 11 in “usage: make error functions a stack”
  1. 1/4 usage: make error functions a stackJacob Keller, Jul 15, 2014
  2. 2/4 tag: fix --sort tests to use cat<<-\EOF formatJacob Keller, Jul 15, 2014
  3. 3/4 tag: update parsing to be more precise regarding errorsJacob Keller, Jul 15, 2014
  4. 4/4 tag: support configuring --sort via .gitconfigJacob Keller, Jul 15, 2014
  5. Jeff KingJul 15, 2014
  6. Keller, Jacob EJul 15, 2014
  7. Junio C HamanoJul 16, 2014
  8. Keller, Jacob EJul 16, 2014
  9. Keller, Jacob EJul 16, 2014
  10. Junio C HamanoJul 16, 2014
  11. Keller, Jacob EJul 16, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.