Re: [PATCH v2 7/7] Rename sort_string_list() to string_list_sort()

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 25, 2014, 18:17 UTC
Message-ID: <xmqq1tortaaq.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1416902555-10748-8-git-send-email-mhagger@alum.mit.edu>

Michael Haggerty <mhagger@alum.mit.edu> writes:

Show 6 quoted lines

> The new name is more consistent with the names of other
> string_list-related functions.
>
> Suggested-by: Junio C Hamano <gitster@pobox.com>
> Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
> ---

Thanks.  I do not think I deserve a credit, though ;-)

Looking at string-list.h, I think this was one of the bigger wart. I think we should do the same for filter_string_list(), but let's worry about it outside this series.

print_string_list() is probably not useful in general use (who uses it???) in the first place, so I do not care too much about it ;-)