git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 5/7] prune_remote(): rename local variable

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Nov 25, 2014, 08:02 UTC
Message-ID
<1416902555-10748-6-git-send-email-mhagger@alum.mit.edu>
In-Reply-To
<1416902555-10748-1-git-send-email-mhagger@alum.mit.edu>

Rename "delete_refs_list" to "refs_to_prune". The new name is more self-explanatory.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
---
 builtin/remote.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/builtin/remote.c b/builtin/remote.c
index 63a6709..efbf5fb 100644
--- a/builtin/remote.c
+++ b/builtin/remote.c
@@ -1311,7 +1311,7 @@ static int prune_remote(const char *remote, int dry_run)
 {
 	int result = 0, i;
 	struct ref_states states;
-	struct string_list delete_refs_list = STRING_LIST_INIT_NODUP;
+	struct string_list refs_to_prune = STRING_LIST_INIT_NODUP;
 	const char *dangling_msg = dry_run
 		? _(" %s will become dangling!")
 		: _(" %s has become dangling!");
@@ -1333,13 +1333,13 @@ static int prune_remote(const char *remote, int dry_run)
 	for (i = 0; i < states.stale.nr; i++) {
 		const char *refname = states.stale.items[i].util;
 
-		string_list_append(&delete_refs_list, refname);
+		string_list_append(&refs_to_prune, refname);
 	}
-	sort_string_list(&delete_refs_list);
+	sort_string_list(&refs_to_prune);
 
 	if (!dry_run) {
 		struct strbuf err = STRBUF_INIT;
-		if (repack_without_refs(&delete_refs_list, &err))
+		if (repack_without_refs(&refs_to_prune, &err))
 			result |= error("%s", err.buf);
 		strbuf_release(&err);
 	}
@@ -1358,9 +1358,9 @@ static int prune_remote(const char *remote, int dry_run)
 			       abbrev_ref(refname, "refs/remotes/"));
 	}
 
-	warn_dangling_symrefs(stdout, dangling_msg, &delete_refs_list);
+	warn_dangling_symrefs(stdout, dangling_msg, &refs_to_prune);
 
-	string_list_clear(&delete_refs_list, 0);
+	string_list_clear(&refs_to_prune, 0);
 	free_remote_ref_states(&states);
 	return result;
 }
-- 
2.1.3
Previous: Michael HaggertyNext: Michael Haggerty
Message 7 of 12 in “repack_without_refs(): convert to string_list”
  1. 0/7 repack_without_refs(): convert to string_listMichael Haggerty, Nov 25, 2014
  2. 1/7 prune_remote(): exit early if there are no stale referencesMichael Haggerty, Nov 25, 2014
  3. Junio C HamanoNov 25, 2014
  4. 2/7 prune_remote(): initialize both delete_refs lists in a single loopMichael Haggerty, Nov 25, 2014
  5. 3/7 prune_remote(): sort delete_refs_list references en masseMichael Haggerty, Nov 25, 2014
  6. 4/7 repack_without_refs(): make the refnames argument a string_listMichael Haggerty, Nov 25, 2014
  7. 5/7 prune_remote(): rename local variableMichael Haggerty, Nov 25, 2014
  8. 6/7 prune_remote(): iterate using for_each_string_list_item()Michael Haggerty, Nov 25, 2014
  9. 7/7 Rename sort_string_list() to string_list_sort()Michael Haggerty, Nov 25, 2014
  10. Junio C HamanoNov 25, 2014
  11. Stefan BellerNov 26, 2014
  12. Junio C HamanoNov 26, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.