Re: [PATCH v2 2/2] git-C: Add test to check "git -C ''"
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 5, 2015, 21:39 UTC
- Message-ID
- <xmqq1tl32kfi.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <1425553031-22264-1-git-send-email-karthik.188@gmail.com>
Karthik Nayak <karthik.188@gmail.com> writes:
> Add a test to check whether "git -C ''" works without giving an > error. This is achieved by adding a commit and checking the log > using "git -C ''" and comparing the log message with the commit > message.
Why choose something complex like commit and log, though?
Wouldn't something like this match the series of current tests better? Also I think a small change with a small test like these should be in a single patch, not two separate ones.
Thanks.
t/t0056-git-C.sh | 10 ++++++++++ 1 file changed, 10 insertions(+)
diff --git a/t/t0056-git-C.sh b/t/t0056-git-C.sh index 99c0377..551d806 100755 --- a/t/t0056-git-C.sh +++ b/t/t0056-git-C.sh @@ -14,6 +14,16 @@ test_expect_success '"git -C <path>" runs git from the directory <path>' ' test_cmp expected actual ' +test_expect_success '"git -C <path>" with an empty <path> is a no-op' ' + ( + mkdir -p dir1/subdir && + cd dir1/subdir && + git -C "" rev-parse --show-prefix >actual && + echo subdir/ >expect + test_cmp expect actual + ) +' + test_expect_success 'Multiple -C options: "-C dir1 -C dir2" is equivalent to "-C dir1/dir2"' ' test_create_repo dir1/dir2 && echo 1 >dir1/dir2/b.txt &&