threads / patch / 38706

v2, 2 partsgit-C: Add test to check "git -C ''"

Subject: [PATCH v2 2/2] git-C: Add test to check "git -C ''"

## tl;dr

3 messages between Mar 5, 2015 and Mar 5, 2015. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Karthik Nayak· Mar 5, 2015, 10:57 UTC · lore

Add a test to check whether "git -C ''" works without giving an error. This is achieved by adding a commit and checking the log using "git -C ''" and comparing the log message with the commit message.

Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
---
 t/t0056-git-C.sh | 10 ++++++++++
 1 file changed, 10 insertions(+)

Show changes to t/t0056-git-C.sh +10 −0

diff --git a/t/t0056-git-C.sh b/t/t0056-git-C.sh
index 99c0377..1cefd4a 100755
--- a/t/t0056-git-C.sh
+++ b/t/t0056-git-C.sh
@@ -1,3 +1,4 @@
+
 #!/bin/sh
 
 test_description='"-C <path>" option and its effects on other path-related options'
@@ -81,4 +82,13 @@ test_expect_success 'Relative followed by fullpath: "-C ./here -C /there" is equ
 	test_cmp expected actual
 '
 
+test_expect_success 'Should not barf when "git -C "" cmd" is used' '
+	echo 1 > a.txt &&
+	msg="initial a.txt" &&
+	(git add a.txt && git commit -m "$msg") &&
+	echo "$msg" >expected &&
+	git -C "" log --format=%s >actual &&
+	test_cmp expected actual
+'
+
 test_done

-- 
2.3.1.167.g7f4ba4b.dirty

karthik nayak· Mar 5, 2015, 11:02 UTC · re: Karthik Nayak · lore

Re: [PATCH v2 2/2] git-C: Add test to check "git -C ''"

On 03/05/2015 04:27 PM, Karthik Nayak wrote:

Show 35 quoted lines

> Add a test to check whether "git -C ''" works
> without giving an error. This is achieved by
> adding a commit and checking the log using
> "git -C ''" and comparing the log message with
> the commit message.
>
> Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
> ---
>   t/t0056-git-C.sh | 10 ++++++++++
>   1 file changed, 10 insertions(+)
>
> diff --git a/t/t0056-git-C.sh b/t/t0056-git-C.sh
> index 99c0377..1cefd4a 100755
> --- a/t/t0056-git-C.sh
> +++ b/t/t0056-git-C.sh
> @@ -1,3 +1,4 @@
> +
>   #!/bin/sh
>
>   test_description='"-C <path>" option and its effects on other path-related options'
> @@ -81,4 +82,13 @@ test_expect_success 'Relative followed by fullpath: "-C ./here -C /there" is equ
>       test_cmp expected actual
>   '
>
> +test_expect_success 'Should not barf when "git -C "" cmd" is used' '
> +    echo 1 > a.txt &&
> +    msg="initial a.txt" &&
> +    (git add a.txt && git commit -m "$msg") &&
> +    echo "$msg" >expected &&
> +    git -C "" log --format=%s >actual &&
> +    test_cmp expected actual
> +'
> +
>   test_done
>

Ignore This, Didnt connect it to the first patch!

Junio C Hamano· Mar 5, 2015, 21:39 UTC · re: Karthik Nayak · lore

Re: [PATCH v2 2/2] git-C: Add test to check "git -C ''"

Karthik Nayak <karthik.188@gmail.com> writes:

> Add a test to check whether "git -C ''" works without giving an
> error. This is achieved by adding a commit and checking the log
> using "git -C ''" and comparing the log message with the commit
> message.

Why choose something complex like commit and log, though?

Wouldn't something like this match the series of current tests better? Also I think a small change with a small test like these should be in a single patch, not two separate ones.

Thanks.

 t/t0056-git-C.sh | 10 ++++++++++
 1 file changed, 10 insertions(+)

Show changes to t/t0056-git-C.sh +10 −0

diff --git a/t/t0056-git-C.sh b/t/t0056-git-C.sh
index 99c0377..551d806 100755
--- a/t/t0056-git-C.sh
+++ b/t/t0056-git-C.sh
@@ -14,6 +14,16 @@ test_expect_success '"git -C <path>" runs git from the directory <path>' '
 	test_cmp expected actual
 '
 
+test_expect_success '"git -C <path>" with an empty <path> is a no-op' '
+	(
+		mkdir -p dir1/subdir &&
+		cd dir1/subdir &&
+		git -C "" rev-parse --show-prefix >actual &&
+		echo subdir/ >expect
+		test_cmp expect actual
+	)
+'
+
 test_expect_success 'Multiple -C options: "-C dir1 -C dir2" is equivalent to "-C dir1/dir2"' '
 	test_create_repo dir1/dir2 &&
 	echo 1 >dir1/dir2/b.txt &&