Re: [PATCH v2 7/7] bisect: allows any terms set by user

From

Junio C Hamano <gitster@pobox.com>

Date

Jun 15, 2015, 16:08 UTC

Message-ID

<xmqq1thdar9u.fsf@gitster.dls.corp.google.com>

In-Reply-To

<vpqoakh74fw.fsf@anie.imag.fr>

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

> I would say terms_defined is OK even if only the first patches get
> merged. The reason why you need this variable is because you need to
> know whether the terms have been defined or not, and to me that's the
> most important.

Well said.  Thanks.

>
> I'd suggest something like this:
>
> # terms_defined is 0 when the user did not define the terms explicitely

s/citely/citly/;

> # yet. This is the case when running 'git bisect start bad_rev good_rev'
> # before we see an explicit reference to a term.
> terms_defined=0
>
> Then PATCH 7/7 can add a mention of 'git bisect terms' just in the
> comment.