Re: [PATCH v2 7/7] bisect: allows any terms set by user

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Jun 17, 2015, 07:05 UTC
Message-ID: <vpq1tha4xxq.fsf@anie.imag.fr>
In-Reply-To: <183774662.562924.1434489533064.JavaMail.zimbra@ensimag.grenoble-inp.fr>

Antoine Delaite <antoine.delaite@ensimag.grenoble-inp.fr> writes:

Show 10 quoted lines

> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>
>># terms_defined is 0 when the user did not define the terms explicitely
>># yet. This is the case when running 'git bisect start bad_rev good_rev'
>># before we see an explicit reference to a term.
>>terms_defined=0
>
> The thing is:
> 'git bisect reset
> git bisect new HEAD

"git bisect new" does not exist. Did you mean "git bisect start HEAD"?

Show 10 quoted lines

> (autostart ?) y'
>
> is strictly equivalent to
>
> 'git bisect reset
> git bisect start
> git bisect new HEAD'
>
> In both case terms_defined value would be 0 while we kinda know that a
> term has been used.

I don't understand. The user didn't say either "bad" or "good", so in both cases we haven't seen a term yet. Or I misunderstood what you meant by "define a term".

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/