Re: [PATCH v4 0/6] refs backend preamble
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 27, 2015, 18:44 UTC
- Message-ID
- <xmqq1tgxf0ub.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <1435379036-30894-1-git-send-email-dturner@twopensource.com>
David Turner <dturner@twopensource.com> writes:
> This version addresses Junio's comments on v3.
The end result makes more sense than the previous one, but did you screw up when rewriting and/or squashing patches around the new 4/6?
I think that one has two separate changes mixed into one and does a lot more than "this is just for clarity". I think they should stay separate, as the other changes are more impactful and deserve their own justification and explanation.
Thanks.