Re: [PATCH v2b 00/16, 2 updates] Make the msvc-build scripts work again

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 21, 2015, 20:04 UTC
Message-ID: <xmqq1tg1uvjk.fsf@gitster.dls.corp.google.com>
In-Reply-To: <xmqqvbdduxd5.fsf@gitster.dls.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 11 quoted lines

> "Philip Oakley" <philipoakley@iee.org> writes:
>
>> ... Ideally, if part of this
>> mainstream Git, it would get picked up automatically by them
>> (rather than being local 'fixes' endlessly carried forward).
>
> Actually, that is not "ideal", but what I want to avoid.
>
> As I do not do Windows, it simply is wrong for me to apply changes
> that are very likely to affect Windows folks without seeing their
> support first,...

Just to clarify this part. I do not do RedHat, Solaris or OSX, either. Also MSVC may not be what GfW folks primarily target.

But the thing is that (1) Windows is so much different, and (2) GfW folks are much more qualified to judge platform-specific issues on Windows than I am.

Even though I may still need to have a say in the overall structure of the changes to the upstream tree coming from them (e.g. "Don't sprinkle #ifdef all over the generic code; instead add a wrapper or two in compat/ to keep the generic code generic" is something I may tell them when rejecting a change forwarded to me), I trust them a lot more than I trust myself when it comes to what the changes do in the platform-specific part and how they do it.

Thanks.