Re: [PATCH v2b 00/16, 2 updates] Make the msvc-build scripts work again

From: Philip Oakley <philipoakley@iee.org>
Date: Jul 21, 2015, 16:46 UTC
Message-ID: <73004CECB3514744A5916831B4501689@PhilipOakley>
In-Reply-To: <xmqq1tg2xwbd.fsf@gitster.dls.corp.google.com>

From: "Junio C Hamano" <gitster@pobox.com>

Show 12 quoted lines

> Philip Oakley <philipoakley@iee.org> writes:
>
>> This updates two patches in the series based on Eric Sunshine's
>> comments.
>>
>> Patch 8b updates the commit message to make clear what was going
>> wrong.
>>
>> Patch 10b improves the perl code.
>
> Is v2b like saying v3 or something else?  Does 8b replaces 8 or
> updates it (i.e. comes between 8 and 9)?

Sorry for the confusion. Yes these are quick replacements, rather than re-rolling the whole series immediately.

Show 6 quoted lines

>
>> Junio: would a full re-roll be appropriate at a suitable point?
>
> Probably, but I'd like to see people try it out and give positive
> feedback first.  This part of the tree I can give no input or pre-
> pushout testing at all.

It has been tried out on the Msysgit list, and also against the github Pull Request, with responses noted there.

I'll do another branch / rebase and PR onto the G4W SDK as well, for an extra chance at getting more replies. Ideally, if part of this mainstream Git, it would get picked up automatically by them (rather than being local 'fixes' endlessly carried forward).

Show 5 quoted lines

>
> Who are the people involved in this part of the system in the past?
> Does "shortlog -n --no-merges contrib/buildsystems compat/vcbuild"
> tell us anything?
>

There has been no activity here on the 'create a visual studio project' aspects in the last few years. Any changes listed in the logs relate to ensuring that the MSVC compiler will run as part of a regular Makefile run (IIUC). The last significant commit was 74cf9bd (engine.pl: Fix a recent breakage of the buildsystem generator, 2010-01-22) Ramsay Jones, so that's five and a half years. Mind you, it's taken me a while to find all the bit rots.

>
>> Philip Oakley (2):
>