Re: [PATCH 3/9] ref-filter: add support for %(path) atom
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 4, 2015, 18:44 UTC
- Message-ID
- <xmqq1tda1njq.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <vpqfv1q5xop.fsf@grenoble-inp.fr>
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
Show 16 quoted lines
>>>> This adds %(path) and %(path:short) atoms. The %(path) atom will print >>>> the path of the given ref, while %(path:short) will only print the >>>> subdirectory of the given ref. >>> >>> What does "path" mean in this context? How is it different from >>> %(refname)? >>> >>> I found the answer below, but I could not guess from the doc and commit >>> message. Actually, I'm not sure %(path) is the right name. If you want >>> the "file/directory" analogy, then %(dirname) would be better. >>> >> >> Noted will change. > > Note: I don't completely like %(dirname) either. I'm convinced it's > better than %(path), but there may be a better option.
Is that a derived form of the refname, just like %(refname:short) that is 'master' for a ref whose %(refname) is 'refs/heads/master' is a derived form of %(refname), and ":short" is what tells the formatting machinery what kind of derivation is desired?
If so would %(refname:dir) & %(refname:base) be more in line with the overall structure?