Re: [PATCH 8/9] branch: use ref-filter printing APIs
- From
Karthik Nayak <karthik.188@gmail.com>
- Date
- Oct 7, 2015, 18:02 UTC
- Message-ID
- <CAOLa=ZQ8QpU_FTqK7Sn0xeygtyirsLOE7bG03iwcVoPUJFpptg@mail.gmail.com>
- In-Reply-To
- <vpqmvvu4l3o.fsf@grenoble-inp.fr>
On Wed, Oct 7, 2015 at 11:28 PM, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:
Show 18 quoted lines
> Karthik Nayak <karthik.188@gmail.com> writes: > >> On Wed, Oct 7, 2015 at 12:33 AM, Matthieu Moy >> <Matthieu.Moy@grenoble-inp.fr> wrote: >> >>> To go a bit further, you can pre-build a string or strbuf aligned_short >>> with value like "%%(align:20,left)%%(refname:short)%%(end)" and use it >>> where needed (it's not a constant because you have to introduce maxwidth >>> into the string, so it's not a candidate for #define). >>> >> >> Again, the remote has a remote prefix here, so we can't really factor >> it out much. > > Ah, OK, there's a %s containing the remote prefix in "remote" that is > not there in "local", and in the last version you sent it's already > factored for verbose > 1 and verbose == 1. Indeed, there's nothing more > to gain here.
I'll send version2 of the patch series to the list then :)
-- Regards, Karthik Nayak