Re: [PATCH 1/2] t8005: avoid grep on non-ASCII data
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 22, 2016, 22:25 UTC
- Message-ID
- <xmqq1t845qmg.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20160222221811.GC18522@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 14 quoted lines
> On Sun, Feb 21, 2016 at 11:41:35PM +0000, John Keeping wrote: > >> My original sed version was: >> >> sed -ne "/^author /p" -e "/^summary /p" >> >> which I think will work on all platforms (we already use it in >> t0000-basic.sh) but then I decided to be too clever :-( >> >> I still think sed is simpler than introducing a new function to wrap a >> perl script. > > Yeah, I think that is good (personally I'd use a function anyway, but I > think it is short enough that we could go either way).
Agreed, and because there are repeated invocation of the same sed script in this file, it would be sensible to hide it behind a helper function.
Thanks.